mcp: fix sseClientConn to use custom HTTP client #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sseClientConn was using http.DefaultClient for requests instead of the custom client provided via SSEClientTransportOptions. This change stores the HTTP client in the sseClientConn struct and uses it for all requests. Also adds test to verify the custom client is properly used.
jba
requested changes
Jul 8, 2025
mcp/sse_test.go
Outdated
| } | ||
|
|
||
| // roundTripperFunc is a helper to create a custom RoundTripper | ||
| type roundTripperFunc struct { |
Contributor
There was a problem hiding this comment.
type roundTripperFunc func(...)
You should be able to write a method on that.
Contributor
|
LGTM. Rob will approve. |
findleyr
reviewed
Jul 8, 2025
Contributor
findleyr
left a comment
findleyr
left a comment
There was a problem hiding this comment.
Thanks for this fix! Once you've addressed Jonathan's comment, we can merge.
findleyr
approved these changes
Jul 8, 2025
jba
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to create an OAuth authentication on top of the SSE transport I discovered the sseClientConn was using http.DefaultClient for requests instead of the custom client provided via SSEClientTransportOptions.
This change stores the HTTP client in the sseClientConn struct and uses it for all requests. Also adds test to verify the custom client is properly used.